Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message for missing tag is misleading #78

Open
v21 opened this issue Jul 26, 2023 · 1 comment · May be fixed by #82
Open

Error message for missing tag is misleading #78

v21 opened this issue Jul 26, 2023 · 1 comment · May be fixed by #82

Comments

@v21
Copy link

v21 commented Jul 26, 2023

If you leave out the "tag" parameter, you get this message: "OAuth identity empty, Maybe you need to populate it in the Secrets for your workflow, see more in https://docs.github.com/en/actions/security-guides/encrypted-secrets and https://tailscale.com/s/oauth-clients".

Ideally it should mention that the tag parameter might be the issue, or ideally flag a unique error.
@thisisparker thisisparker linked a pull request Aug 24, 2023 that will close this issue
Open
@pmocek
Copy link

pmocek commented Dec 12, 2023 •
edited

I see two problems being sort of muddled together, here.

  1. This error message includes a term, "OAuth identity," that is not mentioned in any of Tailscale's OAuth client or GitHub Actions action documentation.
    a. Possibly when @DentonGentry used the term, he meant to refer to the action's oauth-client-id input parameter, which when used must contain what the Tailscale docs refer to as an OAuth client's client ID, which seems to correspond to an OAuth2 client identifier.
    b. Simple solution: s/OAuth identity/OAuth client ID/ or s/OAuth identity/Input parameter oauth-client-id/
  2. This error message is provided not only when an OAuth client ID is expected but not provided, but also when an OAuth secret is provided without the required accompanying set of ACL tags.
    a. The patch supplied by @thisisparker attempts to solve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split OAuth empty error message to create new absent tags error message tailscale/github-action
2 participants
@v21 @pmocek