Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: .github/workflows #47

Open
bradfitz opened this issue Feb 9, 2023 · 1 comment
Open

patch: .github/workflows #47

bradfitz opened this issue Feb 9, 2023 · 1 comment
Labels
tsgo

Comments

@bradfitz
Copy link
Member

bradfitz commented Feb 9, 2023

Summary: add the .github/workflows directory for Tailscale
Upstream status: not applicable. Forever forked.
Example prior commit: 4865b81

When cherry-picking that commit, be sure to add additional tailscale.go1.NN branches to build.yml as needed.
@bradfitz bradfitz added the tsgo label Feb 9, 2023
@bradfitz
Copy link
Member Author

bradfitz commented Feb 9, 2023

Actually, when cherry-picking this, don't. Instead just tar up the old directory and re-add it to the new tree. Otherwise don't forget any other edits to it, e.g. 954407f.

bradfitz pushed a commit that referenced this issue Apr 18, 2023
@ianlancetaylor @gopherbot
cmd/link: don't emit PAX_FLAGS segment on Linux
ffb07d0 
We started emitting this segment in 2012 in CL 6326054 for #47.
It disabled three kinds of protection: mprotect, randexec, and emutramp.
The randexec protection was deprecated some time ago, replaced by PIE.
The emutramp and mprotect protection was because we used to rely on being
able to create writable executable memory to implement function closures,
but that is not true since https://go.dev/s/go11func was implemented.

Change-Id: I5e3a5279d76d642b0423d26195b891479a235763
Reviewed-on: https://go-review.googlesource.com/c/go/+/471199
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@phirework phirework mentioned this issue Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tsgo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradfitz