Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement driver.SessionResetter and driver.Validator so that conns are retained in database/sql pools #70

Open
raggi opened this issue May 23, 2023 · 0 comments · May be fixed by #72
Open

Implement driver.SessionResetter and driver.Validator so that conns are retained in database/sql pools #70

raggi opened this issue May 23, 2023 · 0 comments · May be fixed by #72

Comments

@raggi
Copy link
Member

raggi commented May 23, 2023

We are missing implementations for driver.Validator and driver.SessionResetter that are required in order for connections that have errored to be returned to database/sql connection pools.
raggi added a commit that referenced this issue May 26, 2023
@raggi
sqlite: implement driver.SessionResetter and driver.Validator
ce94160 
These implementations enable us to maintain connections in database/sql
pools.

Fixes #70
@raggi raggi linked a pull request May 26, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sqlite: implement driver.SessionResetter and driver.Validator tailscale/sqlite
1 participant
@raggi