Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL behavior in integration tests #196

Open
AaronFriel opened this issue Jan 24, 2023 · 3 comments
Open

ACL behavior in integration tests #196

AaronFriel opened this issue Jan 24, 2023 · 3 comments

Comments

@AaronFriel
Copy link

AaronFriel commented Jan 24, 2023

Integration tests of the Pulumi provider failed due to the behavior on "create" to set the ts-default tag and error if the ACL was not the default.

Error encountered:

    tailscale:index:Acl (demo-py):
      error: 1 error occurred:
      	* Failed to set ACL: ! You seem to be trying to overwrite a non-default ACL with a tailscale_acl resource.
      Before doing this, please import your existing ACL into Terraform state using:
       terraform import $(this_resource) acl
      (got error "precondition failed, invalid old hash (412)")

Rather than require an import state, it would be nice to allow the user to "force" creation and opt out of the check.

@DentonGentry
Copy link
Contributor

Requiring import was the fix for #182, whatever we do here needs to ensure it doesn't re-introduce the same problem.

@AaronFriel
Copy link
Author

Yeah, I agree with the nature of the safeguard.

Would an additional input forceCreate: bool = false make sense?

@markwellis
Copy link
Contributor

this is a problem I keep running into, a forceCreate option would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants