Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
8
contributors
Commits on Aug 17, 2023
Commits on Aug 21, 2023
-
fix: double onClose on mobile dialog outClick (#2690)
* fix: double onClose on mobile dialog outClick * Fix CS * Add fix to Vue useOutsideClick * Update changelog * Fix CS --------- Co-authored-by: Jordan Pittman <jordan@cryptica.me>
Commits on Aug 22, 2023
-
Lazily resolve default containers in
<Dialog>(#2697)* Lazily resolve default containers in `<Dialog>` * Update changelog
Commits on Aug 23, 2023
-
Fix Portal SSR hydration mismatches (#2700)
* Register portal based on element presence in the DOM This always coincides with `onMounted` currently but that’s about to change * Mount element lazily for portals This prevent’s SSR hydration issues and matches the behavior of React’s `<Portal>` element * Fix portal tests * Update comment * Update changelog
Commits on Aug 28, 2023
-
-
Ensure hidden
TabPanelcomponents are hidden from the accessibility…… tree (#2708) * explicitly add the `aria-hidden="true"` attribute The `Hidden` component only adds the `aria-hidden` by default if the `Focusable` feature is passed. In our case we don't want it to be focusable so therefore we didn't pass this feature flag. Because we didn't pass the `Focusable` feature, the `display: hidden` was used which makes it completely unfocusable to the keyboard of the user which is what we want. However, the VoiceOver cursor _can_ get into those elements. Adding the `aria-hidden` manually to these tabs solves the issue. * update changelog
-
Add support for
role="alertdialog"to<Dialog>component (#2709)* WIP * Add warning for unsupported roles to `<Dialog>` * Update assertions * Add test for React * Add support for `role=alertdialog` to Vue --------- Co-authored-by: Adam Wathan <4323180+adamwathan@users.noreply.github.com>
-
Commits on Aug 29, 2023
-
Ensure blurring the
Combobox.Inputcomponent closes theCombobox(#……2712) * ensure blurring the `Combobox.Input` component closes the `Combobox` * update changelog * select the value on blur if we are in single value mode
Commits on Aug 30, 2023
-
Improve release workflow (#2719)
* add scripts to help with automating releases * add prepare-release and release workflows * bump actions from v2 to v3 * use `github.ref_name` for getting the tag name * ensure we use `**` for matching tags with slashes in them
-
Allow
<button>to be in nested components in<PopoverButton>(#2715)* Tweak `dom()` helper The helper can currently return a component instance when it should only ever return a DOM element. So, we fix the implementation to return null if it’s not an `Element` _and_ adjust the types such that if a `ComponentPublicInstance` is passed we change the return type to `Element`. * Specialize DOM helper to HTML elements Technically it could be an SVG element but much of Headless UI assumes HTML elements all over. So we’ll adjust the types to assume HTMLElement instead. * Allow `dom()` helper to return any `Node` type It doesn’t actually always return an HTMLElement but we have behavior that relies on it returning and checking for `Comment` nodes * Detect `<button>` nested in components inside `<PopoverButton>` * Update changelog
-
Don't overwrite user-defined template refs when rendering (#2720)
* Merge vnode refs when rendering In some cases if we used our own ref (we do this in `<TransitionRoot>` for instance) and rendered slot children we would wipe out user-specified refs. So we set a flag when calling `cloneVNode` to merge our refs and any user-specified refs. * Update changelog
Commits on Aug 31, 2023
-
Add
immediateprop to<Combobox />for immediately opening the Co……mbobox when the `input` receives focus (#2686) * Allow to open combobox on input focus * Close focused combobox with openOnFocus prop when clicking the button * ensure tabbing through a few fields, doesn't result in an incorrectly selected item When you have a fwe inputs such as: ```html <form> <input /> <input /> <input /> <Combobox> <Combobox.Input /> </Combobox> <input /> <input /> <input /> </form> ``` Tabbing through this list will open the combobox once you are on the input field. When you continue tabbing, the first item would be selected. However, if the combobox is not marked as nullable, it means that just going through the form means that we set a value we can't unset anymore. We still want to open the combobox, we just don't want to select anything in this case. * only `openOnFocus` if the `<Combobox.Input />` is focused from the outside If the focus is coming from the `<Combobox.Button />` or as a side effect of selecting an `<Combobox.Option />` then we don't want to re-open the `<Combobox />` * update tests to ensure that the `Combobox.Input` is the active element * order `handleBlur` and `handleFocus` the same way in Vue & React * only select the active option when the Combobox wasn't opened by focusing the input field * convert to `immediate` prop on the `Combobox` itself * update changelog * ensure we see the "relatedTarget" in Safari Safari doesn't fire a `focus` event when clicking a button, therefore it does not become the `document.activeElement`, and events like `blur` or `focus` doesn't set the button as the `event.relatedTarget`. Keeping track of a history like this solves that problem. We already had the code for the `FocusTrap` component. --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
-
Allow changes to the
classNameprop when the<Transition />compo……nent is currently not transitioning (#2722) * allow changes to the `className` when we are _not_ transitioning * update changelog
-
Export component interfaces and mark them as internal (#2313)
* export component interfaces, and mark them as internal This is not ideal because we don't want these to be public. However, if you are creating components on top of Headless UI, the TypeScript compiler needs access to them. So now they are public in a sense, but you shouldn't be interacting with them directly. Co-authored-by: Jordan Pittman <jordan@cryptica.me> * Update changelog --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
Commits on Sep 11, 2023
-
Sort imports automatically (#2741)
* add `prettier-plugin-organize-imports` and `prettier-plugin-tailwindcss` * format * bump Tailwind CSS * format playgrounds using updated Tailwind CSS and Prettier plugins * use import syntax
-
Commits on Sep 15, 2023
-
Add
virtualprop toComboboxcomponent (#2740)* type timezones in playground data * add `@tanstack/react-virtual` and `@tanstack/vue-virtual` * use latest stable Tailwind CSS version * add Combobox with virtual prop example * add `virtual` prop to `Combobox` Co-authored-by: Jordan Pittman <jordan@cryptica.me> * add tests for `virtual` prop - Also wrap `click` helpers in `act` for React (use `rawClick` without `act` in tests related to `Transition`) * update changelog --------- Co-authored-by: Jordan Pittman <jordan@cryptica.me>
Commits on Sep 20, 2023
-
Make sure
as={Fragment}doesn’t result in a render loop (#2760)* Make sure `as={Fragment}` doesn’t result in a render loop * Add comment about usage * Fix render loop on popover panel too * Update changelog
Commits on Oct 2, 2023
-
Implement new
virtualAPI for theComboboxcomponent (#2779)* add `(Vue)` or `(React)` to playground header * show amount of items in virtualized example * improve calculating the active index * disable strict mode * update virtualized playground examples with preferred API * optimize `calculateActiveIndex` * implement new `virtual` API * update changelog
Commits on Oct 4, 2023
-
Fix state data attribute in Vue (#2787)
* Add tests * Fix state data attribute in Vue
-
Commits on Nov 2, 2023
-
Fix VoiceOver bug for
Listboxcomponent in Chrome (#2824)* fix VoiceOver bug for Listbox in Chrome Chrome currently has a bug if you use a `Listbox` with a `Label` and use the `aria-multiselectable` attribute. This combination will cause VoiceOver to _not_ announce the `role="option"` elements when interacting with them. If we drop the `aria-multiselectable` OR the `aria-labelledby` it starts working. Alternatively replacing `aria-labelledby` with `aria-label` won't work either. I filed a Chrome bug report about this here: https://bugs.chromium.org/p/chromium/issues/detail?id=1498261 --- Luckily there is a workaround in our `Listbox` implementation. Right now we always require the `Listbox.Button` to be there. The `Listbox.Options` component doesn't work on its own in our implementation. This means that whenever we open the `Listbox` that we have to go via the `Listbox.Button`. This `Listbox.Button` is already labelled by the `Listbox.Label` if there is one. This also means that we can safely drop the `id` of the label inside the `aria-labelledby` from the `Listbox.Options`. This wouldn't have worked if our `Listbox.Options` could be used in a standalone way without the `Listbox.Button`. At the end of the day the hierarchy looks like this: - Options is labelled by the Button - Button is labelled by the Label - Label Fixes: #2817 * update changelog
Commits on Nov 17, 2023
Commits on Dec 5, 2023
-
Fix outside click detection when component is mounted in the Shadow D…
…OM (#2866) * Fix outside click detection when component is mounted in the Shadow DOM * Fix code style * Fix error
-
Commits on Dec 12, 2023
-
* Fix Vue type error * Add separate CTS types * Add “Are The Types Wrong” CLI * wip * Bump node versions in workflows * wip * wip * wip * yolo * yolo (again?) * wip * wip
-
Fix error when transition classes contain new lines (#2871)
* fix DOMException when remove class with '\n' character in react 'transition' component * Split classes on all whitespace * Revert "fix DOMException when remove class with '\n' character in react 'transition' component" This reverts commit 76e8354. * fix typo * Add test * Fix CS * Update changelog --------- Co-authored-by: Jordan Pittman <jordan@cryptica.me>
-
Commits on Jan 6, 2024
-
-
fix incorrect
activeIndexwhen handlingFocus.PreviousThis is already available in the React version, now let's sync it in the Vue version as well.
-
improve iOS scroll locking (Vue)
The scroll locking on iOS was flickering in some scenario's due to the `window.scrollTo(0, 0)` related code. Instead of that, we now cancel touch moves instead but still allow it in scrollable containers inside the Dialog itself. This was already applied in the React version, but this adds the same improvement to the Vue version as well.
There are no files selected for viewing