Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comboboxes in modal dialogs - Esc key not working #1506

Closed
jdlien opened this issue May 26, 2022 · 3 comments · Fixed by #1511
Closed

Comboboxes in modal dialogs - Esc key not working #1506

jdlien opened this issue May 26, 2022 · 3 comments · Fixed by #1511
Assignees

Comments

@jdlien
Copy link

jdlien commented May 26, 2022

What package within Headless UI are you using?

@headlessui/vue

What version of that package are you using?

v1.6.3

What browser are you using?

Chrome 101, Firefox 100

Reproduction URL

https://github.com/EPLibrary/esc-bug

Describe your issue

This project demonstrates a bug with comboboxes in modal dialogs in recent versions of
HeadlessUI. This applies to contexts such as TailwindUI's command palettes.

When the combobox input has focus, pressing esc does not close the dialog.

Pressing esc does work properly if you click just below the input inside of the modal.

HeadlessUI v.1.6.1 works fine, but v.1.6.2 does not.
You can test this by downgrading headlessui to v.1.6.1 and running npm install, then rebuilding this project.

@RobinMalfait
Copy link
Collaborator

RobinMalfait commented May 27, 2022

Hey! Thank you for your bug report!
Much appreciated! 🙏

Good catch! This was sort of a regression, sorry about that!

This should be fixed by #1511, and will be available in the next release.

You can already try it using npm install @headlessui/vue@insiders.

@jdlien
Copy link
Author

jdlien commented May 27, 2022

Awesome! Thanks so much for fixing this so quickly.

@jdlien
Copy link
Author

jdlien commented May 27, 2022

I have tested with @insiders and this appears to fix the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants