Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog.Overlay does not stop propagation #1601

Closed
binajmen opened this issue Jun 18, 2022 · 1 comment
Closed

Dialog.Overlay does not stop propagation #1601

binajmen opened this issue Jun 18, 2022 · 1 comment
Assignees

Comments

@binajmen
Copy link

binajmen commented Jun 18, 2022

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

v1.6.4

What browser are you using?

Chrome

Reproduction URL

https://stackblitz.com/edit/headlessui-popover-overlay-mobile-y3dsic?file=App.tsx

Describe your issue

When clicking outside the Dialog, the element behind the overlay is activated on mobile (part 1 of the short clip). It seems to stop the propagation on Desktop (part 2 of the short clip – I'm clicking a second time to show the alert).

Screen.Recording.2022-06-18.at.08.36.46.mov

It has already been reported for Popover: #1418. Perhaps similar solution/issue?

@RobinMalfait RobinMalfait self-assigned this Jun 20, 2022
@RobinMalfait
Copy link
Collaborator

Hey! Thank you for your bug report!
Much appreciated! 🙏

This should have already been fixed by #1546, and will be available in the next release.

You can already try it using:

  • npm install @headlessui/react@insiders.
  • npm install @headlessui/vue@insiders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants