Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: The aria-expanded attribute should be rendered on the ComboboxInput #1604

Closed
lebowska opened this issue Jun 18, 2022 · 1 comment · Fixed by #1605
Closed
Assignees

Comments

@lebowska
Copy link

What package within Headless UI are you using?

@headlessui/vue

What version of that package are you using?

For example: v1.6.4

What browser are you using?

Chrome

Reproduction URL

Your Vue Combobox (Autocomplete) demo at https://headlessui.dev/vue/combobox

Describe your issue

The "aria-expanded" attribute should be rendered on the ComboboxInput too. I see that it's correctly rendered on the ComboboxButton, but being the ComboboxInput a role of type "combobox", it sould always requires the "aria-expanded" attribute, as stated here:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/combobox_role
"A WAI-ARIA combobox only has one attribute that is required that authors specify: [aria-expanded]"

I also see that the React version correctly renders the attribute on both the button and the input, so I think it could be a bug on the Vue version of the input component.

Thank for your hard work

Screenshot 2022-06-18 160528

@RobinMalfait
Copy link
Collaborator

Hey! Thank you for your bug report!
Much appreciated! 🙏

This should be fixed by #1605, and will be available in the next release.

You can already try it using npm install @headlessui/vue@insiders.


I also updated the docs to reflect this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants