Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox active index styling not resetting correctly #2447

Closed
JamesNuttall opened this issue Apr 21, 2023 · 1 comment · Fixed by #2463
Closed

Combobox active index styling not resetting correctly #2447

JamesNuttall opened this issue Apr 21, 2023 · 1 comment · Fixed by #2463
Assignees

Comments

@JamesNuttall
Copy link

JamesNuttall commented Apr 21, 2023

Package Version: @headlessui/vue v1.7.13
Reproduction URL: https://stackblitz.com/edit/combobox-issue?file=src/App.vue

Issue

As can be seen in the video below, when the results are changed the active styling isn't being updated and set onto the correct index, its staying on index 1 despite the activeIndex being 0.

Clip1.mov

In the next clip you can see (at about 10s) that because of the above when I press the down arrow key nothing seems to happen as the styling is incorrectly assigned to the option at index 1 instead of being reset back to index 0, therefor it takes two arrow key press to get any feedback.

Clip2.mov
@JamesNuttall JamesNuttall changed the title Combobox Active Index not resetting correctly Combobox active index styling not resetting correctly Apr 21, 2023
@RobinMalfait RobinMalfait self-assigned this Apr 26, 2023
@RobinMalfait
Copy link
Collaborator

Hey, thank you for this bug report! 🙏

This should be fixed by #2463, and will be available in the next release.

You can already try it using:

  • npm install @headlessui/vue@insiders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants