Ensure the Transition stops once DOM Nodes are hidden #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix an issue where the
onStopcallback internally is never called if the DOM nodebecomes hidden.
This happens when you use the
Transitioncomponent in combination with theDialogcomponent.When the
Dialogbecomes "hidden", then we unmount everything, however transitions don't seem torun, end or cancel on hidden DOM nodes. This causes an issue where "hidden" DOM nodes had a pending
transition.
This pending transition prevented
<Transition.Child>and<Transition>components higher up thetree from unmounting. This in turn resulted in the
Dialognot completely unmounting properly.Fixes: #1417
Fixes: tailwindlabs/tailwindui-issues#1215