Detect outside clicks from within <iframe> elements
#1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
force-pushed
the
fix/support-iframe-outside-click
branch
from
e258820
to
ffb3b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page has a component like
<Menu>and and<iframe>on the page you could click inside the iframe. These click events are not delivered to theWindowthat contains the iframe so menus, dialogs, etc will not close. However, when clicking or focusing anything inside the iframe the Window receives theblurevent anddocument.activeElementchanges to the iframe itself. We can use this to detect a click or change in focus targeted at an iframe. We're also sure to scope this so if you have an iframe inside your Menu, Listbox, etc… that it doesn't close.Fixes #707