Only render the Dialog on the client
#1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
fix/dialog-client-only
branch
from
7c666a3
to
10ebf51
Compare
RobinMalfait
force-pushed
the
fix/dialog-client-only
branch
from
10ebf51
to
00f11ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with our Dialog components in Vue and server side rendering.
Right now, we will only render the Dialog component on the client and not on the server.
Once we figure out the correct way of server side rendering the Dialog then we can revisit this
behaviour. But for now, this at least fixes incorrect SSR and hydration issues where closing the
Dialog looks like it is still there even though that's the static SSR version of the Dialog.
Fixes: tailwindlabs/tailwindui-issues#1223