Ignore mouse move/leave events when the cursor hasn’t moved #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
reviewed
Dec 5, 2022
A mouse enter / leave event where the cursor hasn’t moved happen only because of: - Scrolling - The container moved
RobinMalfait
force-pushed
the
fix/ignore-mouse-move-without-delta
branch
from
419e8fe
to
6d4c8fb
Compare
|
@RobinMalfait I've tweaked the implementation slightly with how it bypasses checks during tests. It now only does so for the pointer event calls in JSDOM. I use an env var to do this which required a tweak to the build script to make sure it was removed at compile time for release builds. Any worries with this approach? If not them I'll merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mouse enter / leave event where the cursor hasn’t moved could only happen because the container moved under the cursor. This is typically the result of scrolling the parent container (but could because by other move-related situations as well, if you're moving things around with JS for instance).
Some browsers (like Chrome) will prevent these events from firing when a scroll would've caused them; however, Safari isn't smart enough to do this (or maybe it's an intentional decision — not sure).
Regardless, this is not a desirable behavior because when using the up/down arrows to move through a list the mouse move event will trigger if it happens to be in the area where an option would move to causing the focus to move to an option other than the one you intended.
@RobinMalfait pls tell me this makes sense lol
Should fix this once things are merged, tagged, and updated: tailwindlabs/tailwindui-issues#1378