Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding default in v3 doesn't mention it should be UPPERCASE #1114

Closed
igor-krupa opened this issue Jan 6, 2022 · 3 comments
Closed

Overriding default in v3 doesn't mention it should be UPPERCASE #1114

igor-krupa opened this issue Jan 6, 2022 · 3 comments

Comments

@igor-krupa
Copy link

igor-krupa commented Jan 6, 2022

I've recently updated to v3. I previously have some default boxShadow styles overridden with default key. But now it should be DEFAULT. Also, bit weird that only for boxShadow should be uppercase?
With lowercase it does not produce .shadow class in css.
Documentation or migration guide does not mention that.

@reinink
Copy link
Member

reinink commented Jan 6, 2022

Hey!

So this actually changed in Tailwind CSS v.2.0. You can find that PR here:

tailwindlabs/tailwindcss#2580

This was included in the migration guide for 2.0, which you can find here:

https://v2.tailwindcss.com/docs/upgrading-to-v2#update-default-theme-keys-to-default

Hope that helps 👍

@reinink reinink closed this as completed Jan 6, 2022
@kevinruscoe-popcreative

Sorry for reopening this, it seems the v3 documentation doesn't mention the DEFAULT keyword at all, is hat intentional?

@reinink
Copy link
Member

reinink commented Jan 14, 2022

@kevinruscoe-popcreative Hey! It is actually mentioned on the theme page under "Core plugins":

You’ll notice that using a key of DEFAULT in the theme configuration created the class rounded with no suffix. This is a common convention in Tailwind and is supported by all core plugins.

Easy to miss though. You can also see examples of using DEFAULT in our default config here:

https://github.com/tailwindlabs/tailwindcss/blob/master/stubs/defaultConfig.stub.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants