From ea139f20a2e2f2bab852d80de361db8fbd2a4468 Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Fri, 3 Dec 2021 19:23:01 +0100 Subject: [PATCH] Improve `[0]` arbitrary value support (#6259) * test `text-[0]` instead of `w-[0]` * update changelog --- CHANGELOG.md | 2 +- src/util/dataTypes.js | 2 +- tests/arbitrary-values.test.css | 3 +++ tests/arbitrary-values.test.html | 1 + 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3bf9ac67250d..b5fab2efb066 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,7 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add `portrait` and `landscape` variants ([#6046](https://github.com/tailwindlabs/tailwindcss/pull/6046)) - Add `text-decoration-style`, `text-decoration-thickness`, and `text-underline-offset` utilities ([#6004](https://github.com/tailwindlabs/tailwindcss/pull/6004)) - Add `menu` reset to preflight ([#6213](https://github.com/tailwindlabs/tailwindcss/pull/6213)) -- Allow `0` as a valid `length` value ([#6233](https://github.com/tailwindlabs/tailwindcss/pull/6233)) +- Allow `0` as a valid `length` value ([#6233](https://github.com/tailwindlabs/tailwindcss/pull/6233), [#6259](https://github.com/tailwindlabs/tailwindcss/pull/6259)) - Add css functions to data types ([#6258](https://github.com/tailwindlabs/tailwindcss/pull/6258)) ### Changed diff --git a/src/util/dataTypes.js b/src/util/dataTypes.js index f5c73536acdc..1838be619d47 100644 --- a/src/util/dataTypes.js +++ b/src/util/dataTypes.js @@ -81,7 +81,7 @@ let lengthUnits = [ let lengthUnitsPattern = `(?:${lengthUnits.join('|')})` export function length(value) { return ( - value === 0 || + value === '0' || new RegExp(`${lengthUnitsPattern}$`).test(value) || cssFunctions.some((fn) => new RegExp(`^${fn}\\(.+?${lengthUnitsPattern}`).test(value)) ) diff --git a/tests/arbitrary-values.test.css b/tests/arbitrary-values.test.css index 29de7a50cc59..4a53a5f5dc1e 100644 --- a/tests/arbitrary-values.test.css +++ b/tests/arbitrary-values.test.css @@ -764,6 +764,9 @@ .font-\[\'Some_Font\'\2c var\(--other-font\)\] { font-family: 'Some Font', var(--other-font); } +.text-\[0\] { + font-size: 0; +} .text-\[2\.23rem\] { font-size: 2.23rem; } diff --git a/tests/arbitrary-values.test.html b/tests/arbitrary-values.test.html index ca138b510af0..4e38751cddf8 100644 --- a/tests/arbitrary-values.test.html +++ b/tests/arbitrary-values.test.html @@ -278,6 +278,7 @@
+