Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove menu element styles #6213

Merged
merged 2 commits into from Nov 29, 2021
Merged

Remove menu element styles #6213

merged 2 commits into from Nov 29, 2021

Conversation

AviAvinav
Copy link
Contributor

@AviAvinav AviAvinav commented Nov 28, 2021

Removed the default spacing and set list-style-type to none for the menu element.

To fix issue: #6191

P.S. - This is my first pull request so please forgive any mistakes.

@adamwathan
Copy link
Member

Hey thanks! I think this should be menu not main right? Let's just add it to the list here since the reset is for the same purpose:

https://github.com/tailwindlabs/tailwindcss/blob/master/src/css/preflight.css#L290-L295

@AviAvinav
Copy link
Contributor Author

AviAvinav commented Nov 29, 2021

Oops! Sorry, my bad, will fix it.

@AviAvinav AviAvinav changed the title Remove main element styles Remove menu element styles Nov 29, 2021
@AviAvinav
Copy link
Contributor Author

Hey thanks! I think this should be menu not main right? Let's just add it to the list here since the reset is for the same purpose:

https://github.com/tailwindlabs/tailwindcss/blob/master/src/css/preflight.css#L290-L295

Thanks for pointing it out. Fixed it.

@RobinMalfait RobinMalfait merged commit f267d91 into tailwindlabs:master Nov 29, 2021
@RobinMalfait
Copy link
Contributor

Hey! Thank you for your PR!
Much appreciated! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants