Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for negative values in safelist patterns #6480

Merged
merged 1 commit into from Dec 14, 2021
Merged

Add support for negative values in safelist patterns #6480

merged 1 commit into from Dec 14, 2021

Conversation

mwnciau
Copy link
Contributor

@mwnciau mwnciau commented Dec 13, 2021

This is a fix for #6476, where negative values aren't being matched by safelist patterns. This PR:

  • Adds negative values (where supported) to the list of classes that the safelist patterns are compared to
  • Adds a test for matching negative values in the safelist

@mwnciau mwnciau changed the title Support for negative values in safelist patterns Add support for negative values in safelist patterns Dec 14, 2021
@mwnciau mwnciau force-pushed the negative-safelist-pattern branch 2 times, most recently from 241af35 to 94b2e36 Compare December 14, 2021 13:08
@thecrypticace thecrypticace merged commit a7263a8 into tailwindlabs:master Dec 14, 2021
@thecrypticace
Copy link
Contributor

Awesome — thanks for taking care of this! 🎉

@mwnciau mwnciau deleted the negative-safelist-pattern branch December 15, 2021 08:17
@mwnciau mwnciau mentioned this pull request Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwnciau @thecrypticace