Revert "Only listen for stdin close on TTYs (#8523)" #9331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 14f6574.
This was originally done to fix issues with Turborepo but it had some unforeseen side effects that would leave dangling processes. For things that use Erlang (for example Phoenix) this is a problem because Erlang does not have the necessary APIs to send signals to processes — instead relying only on stdin closing behavior or wrapper scripts to work around this.
As a bonus it seems that Turborepo has updated their official tailwind example to use
concurrentlywhich sidesteps this problem entirely because it acts as the wrapper in this case and handles stdin for child processes appropriately.Fixes #9264