Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salient Template problematic autoscrolling #1467

Closed
BernhardBehrendt opened this issue Jun 28, 2023 · 1 comment
Closed

Salient Template problematic autoscrolling #1467

BernhardBehrendt opened this issue Jun 28, 2023 · 1 comment
Assignees

Comments

@BernhardBehrendt
Copy link

What component (if applicable)
Salient Template

Describe the bug
When I scroll down to the images of the Secondary Features section so that just the last line of text of the above text is visible and then click on that text the scroll position changes and page scrolls up.

But it does not scroll up until the beginning of that section but all the way up so that the image is only visible half, even though there's enough space on the screen if the scrolling would move until the real beginning of that section

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://salient.tailwindui.com/
  2. Scroll to Secondary Features section so that you see the whole image and the last line of the above Text blocks
  3. Click on a text which is yet not selected (2nd, 3rd)
  4. See error

Expected behavior
The scroll position is applied that places the text blocks on top of the page and not "somewhere" in between resulting in a sliced image view.

Screenshots
If applicable, add screenshots to help explain your problem.

Browser/Device (if applicable)

  • OS: Mac
  • Browser Chrome, Brave (latest)
@reinink
Copy link
Member

reinink commented Aug 17, 2023

Hey! Thanks for reporting this issue. This was actually a bug in our underlying Headless UI library, which is used for the tabs in this template. I've corrected this bug there: tailwindlabs/headlessui#2674

I've already updated our template to use the latest version of Headless UI that includes this fix, and you can see that it's been resolved in our template preview here: https://salient.tailwindui.com/

If you'd like to fix this in your project, simply update to the latest version of Headless UI:

npm install @headlessui/react@latest

Hope that helps, and thanks again! 🙏

@reinink reinink closed this as completed Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants