Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

讨论:配置文件优化 #756

Open
suxb201 opened this issue Jan 3, 2024 · 1 comment
Open

讨论:配置文件优化 #756

suxb201 opened this issue Jan 3, 2024 · 1 comment
Assignees

Comments

@suxb201
Copy link
Member

suxb201 commented Jan 3, 2024

当前版本配置文件:

function = ""


[sync_reader]
# ...


[redis_writer]
# ...

[advanced]
# ...

[module]
# ...

计划改动为:

[sync_reader]
# ...


[redis_writer]
# ...

[filter]
allow_key_prefix = "myapp"
allow_key_suffix = "myapp"
block_key_prefix = "myapp"
block_key_suffix = "myapp"

allow_db = []
block_db = []

allow_command = []
block_command = []

allow_command_group = []
block_command_group = []

function = ""

[advanced]
# ...

改动有:

  1. 新增 filter,里面增加常用的过滤选项,基于 luafunction 过滤作为备用选项。好处有亮点:a. 多数场景下用户配置更方便,不需要去写 lua 脚本 b. RedisShake 过滤效率更高
  2. module 放到 advanced 中,低频配置应该更隐藏,避免给常用场景造成干扰。
  3. 其余考虑的点:target_redis_proto_max_bulk_len 是否需要换个名字,从 issue 来看,这个配置使用频率比较高。

个人意见,欢迎大家提出别的看法。

@suxb201 suxb201 added the type: feature request New feature or request label Jan 3, 2024
@suxb201 suxb201 self-assigned this Jan 3, 2024
@suxb201 suxb201 changed the title 配置文件逻辑优化 配置文件优化 Jan 3, 2024
@suxb201 suxb201 changed the title 配置文件优化 讨论:配置文件优化 Jan 3, 2024
@suxb201 suxb201 added type: discussion and removed type: feature request New feature or request labels Jan 3, 2024
@135zyf
Copy link

135zyf commented Jan 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants