Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMR does not seem to work on .ladle/components.tsx #490

Open
Lillebo opened this issue Sep 13, 2023 · 1 comment
Open

HMR does not seem to work on .ladle/components.tsx #490

Lillebo opened this issue Sep 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Lillebo
Copy link

Lillebo commented Sep 13, 2023

Is your feature request related to a problem? Please describe.

I use .ladle/components.tsx to import some global styles shared by all components. Changes to the stylesheets imported into .ladle/components.tsx does not seem to be detected and/or trigger any browser reload. In fact, it doesn't even work to manually refresh the browser for these changes to take effect. You have to restart the entire ladle runtime for the changes to take effect.

Describe the solution you'd like
I'd like HMR to work with changes to .ladle/components.tsx and files/packages/dependencies imported/referenced there.

Describe alternatives you've considered
...

Additional context
...
@Lillebo Lillebo added the needs triage needs to be reviewed label Sep 13, 2023
@tajo tajo added enhancement New feature or request and removed needs triage needs to be reviewed labels Sep 13, 2023
@tajo
Copy link
Owner

tajo commented Sep 13, 2023

Might be a bit tricky to make these HMR-able but at least we should try to make it refreshable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lillebo @tajo