Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Includes declaration maps #5231

Merged
merged 2 commits into from Apr 24, 2023
Merged

Conversation

ekwoka
Copy link
Contributor

@ekwoka ekwoka commented Apr 6, 2023

Including declaration maps allows typescript/vscode to go to the proper source file when doing go to definition instead of only going to a declaration file of the types (often unhelpful). This aids to source diving to understand the package.

Simple change, big impact.

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Apr 24, 2023 11:35am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da4db22:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@nx-cloud
Copy link

nx-cloud bot commented Apr 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit da4db22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.78 ⚠️

Comparison is base (88f144c) 97.01% compared to head (cabef9f) 92.23%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5231      +/-   ##
==========================================
- Coverage   97.01%   92.23%   -4.78%     
==========================================
  Files          10      111     +101     
  Lines         368     4248    +3880     
  Branches      134     1105     +971     
==========================================
+ Hits          357     3918    +3561     
- Misses         11      309     +298     
- Partials        0       21      +21     
Impacted Files Coverage Δ
packages/react-query-devtools/src/devtools.tsx 89.06% <100.00%> (ø)

... and 100 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo merged commit 7cd2d19 into TanStack:main Apr 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants