Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DTE to the PR workflow #5256

Merged
merged 19 commits into from
Apr 28, 2023
Merged

Adding DTE to the PR workflow #5256

merged 19 commits into from
Apr 28, 2023

Conversation

ZackDeRose
Copy link
Contributor

@ZackDeRose ZackDeRose commented Apr 11, 2023

What it does

Uses distributed task execution for the PR workflow - this way we can get better utilization out of the machines we use for the pr workflow.

NOTES for alpha branch:

The React 17 flow can obviously go away. The format task is not cacheable by design, so we probably should continue to run that as it's own job in parallel.

@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Apr 28, 2023 9:01am

@nx-cloud
Copy link

nx-cloud bot commented Apr 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dc1ad35. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc1ad35:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +92.26 🎉

Comparison is base (195772e) 0.00% compared to head (80fb08f) 92.26%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #5256       +/-   ##
=========================================
+ Coverage      0   92.26%   +92.26%     
=========================================
  Files         0      112      +112     
  Lines         0     4267     +4267     
  Branches      0     1111     +1111     
=========================================
+ Hits          0     3937     +3937     
- Misses        0      309      +309     
- Partials      0       21       +21     

see 112 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZackDeRose
Copy link
Contributor Author

Hey @TkDodo! Anything else needed in this PR?

I'd estimate this is roughly a 10-25% improvement to the pr workflow timings - which is still good, but I think adding the task caching + filtering to only run affected tasks was an order of magnitude more impactful

@ZackDeRose
Copy link
Contributor Author

Time Investigation

With DTE: 2m48s long stick (https://github.com/TanStack/query/actions/runs/4805517871/jobs/8552011511?pr=5256)
Without DTE: 3m21s long stick (https://github.com/ZackDeRose/query/actions/runs/4805602190/jobs/8552179929)

Result: 16.4% time improvement ((201 - 168) / 201)

(used with cold caches to preserve like-for-like comparisons)

@TkDodo TkDodo merged commit 373b5d5 into TanStack:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants