-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DTE to the PR workflow #5256
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dc1ad35. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dc1ad35:
|
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #5256 +/- ##
=========================================
+ Coverage 0 92.26% +92.26%
=========================================
Files 0 112 +112
Lines 0 4267 +4267
Branches 0 1111 +1111
=========================================
+ Hits 0 3937 +3937
- Misses 0 309 +309
- Partials 0 21 +21 see 112 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Hey @TkDodo! Anything else needed in this PR? I'd estimate this is roughly a 10-25% improvement to the pr workflow timings - which is still good, but I think adding the task caching + filtering to only run affected tasks was an order of magnitude more impactful |
Time InvestigationWith DTE: 2m48s long stick (https://github.com/TanStack/query/actions/runs/4805517871/jobs/8552011511?pr=5256) Result: 16.4% time improvement ((201 - 168) / 201) (used with cold caches to preserve like-for-like comparisons) |
What it does
Uses distributed task execution for the PR workflow - this way we can get better utilization out of the machines we use for the pr workflow.
NOTES for alpha branch:
The React 17 flow can obviously go away. The format task is not cacheable by design, so we probably should continue to run that as it's own job in parallel.