Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix restore loading not working when clicked repeatedly #5311

Merged
merged 6 commits into from
Apr 28, 2023

Conversation

prateek3255
Copy link
Contributor

Fixes #5157

Checkout this comment for a detailed description of this change fixes the issue

@vercel
Copy link

vercel bot commented Apr 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Apr 28, 2023 2:28pm

@nx-cloud
Copy link

nx-cloud bot commented Apr 22, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bcbac25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bcbac25:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration
react-query-dev-tools-trigger-loading-bug Issue #5157

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +88.80 🎉

Comparison is base (195772e) 0.00% compared to head (f3bdfc7) 88.80%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #5311       +/-   ##
=========================================
+ Coverage      0   88.80%   +88.80%     
=========================================
  Files         0       11       +11     
  Lines         0      643      +643     
  Branches      0      239      +239     
=========================================
+ Hits          0      571      +571     
- Misses        0       66       +66     
- Partials      0        6        +6     
Impacted Files Coverage Δ
packages/react-query-devtools/src/devtools.tsx 88.88% <75.00%> (ø)

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a test that covers this scenario? Ideally, one that failed before and doesn't fail after the fix 🙏

@prateek3255
Copy link
Contributor Author

Added a test @TkDodo, also verified that it fails with the same error if I remove the fix:
image

@TkDodo TkDodo merged commit b97cd50 into TanStack:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev-tools error on 'Trigger Loading' clicking for slower networks.
3 participants