docs: vue examples #607
Merged
docs: vue examples #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouts
commented
Oct 15, 2023
|
|
||
| const sorting = ref<SortingState>([]) | ||
|
|
||
| const getSortingHandler = (e: Event, fn: any) => { |
There was a problem hiding this comment.
I couldn't figure out the type for this function here.
Comment on lines
+92
to
+96
| const setSorting = (sortingUpdater: any) => { | ||
| const newSortVal = sortingUpdater(sorting.value) | ||
|
|
||
| sorting.value = newSortVal | ||
| } |
There was a problem hiding this comment.
Same here, I couldn't figure out the type for the sortingUpdater function.
kouts
force-pushed
the
docs/vue-examples
branch
from
fe6f54b
to
badb584
Compare
kouts
commented
Oct 16, 2023
| @@ -26,12 +26,12 @@ function ReactTableVirtualized() { | |||
| }, | |||
There was a problem hiding this comment.
This file only contains formatting changes due to prettier being applied.
| @@ -11,7 +11,7 @@ | |||
| "linkAll": "lerna exec 'npm link' --parallel", | |||
| "unlinkAll": "lerna exec 'npm unlink' --parallel", | |||
| "dev": "npm run clean && npm run watch", | |||
| "prettier": "prettier \"packages/*/{src/**,examples/**/src/**}.{md,js,jsx,ts,tsx,json}\" --write", | |||
| "prettier": "prettier \"{packages/*/src/**,examples/*/*/src/**}.{md,js,jsx,ts,tsx,vue,json}\" --write", | |||
There was a problem hiding this comment.
Added the .vue extension and fixed the prettier command glob so that it takes into account the examples as well.
|
Thanks @kouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great library and for making the Tanstack framework-agnostic!
This PR adds the following examples for Vue:
The
paddingexamples are still pending, but I believe this is a good start.PS: I tried running the docs locally but couldn't figure it out, it would be nice if we can have some instructions on how to do that.