Skip to content

Commit

Permalink
fix: export types IdIdentifier, StringHeaderIdentifier, AccessorKeyCo…
Browse files Browse the repository at this point in the history
…lumnDefBase (#5133)

fixes those build issues:
TS4023: Exported variable 'myHook' has or is using name 'AccessorKeyColumnDefBase' from external module ".../node_modules/@tanstack/table-core/build/lib/types" but cannot be named.
TS4023: Exported variable 'myHook' has or is using name 'IdIdentifier' from external module ".../node_modules/@tanstack/table-core/build/lib/types" but cannot be named.
TS4023: Exported variable 'myHook' has or is using name 'StringHeaderIdentifier' from external module ".../node_modules/@tanstack/table-core/build/lib/types" but cannot be named.
  • Loading branch information
maxence-lefebvre committed Dec 20, 2023
1 parent c214ab3 commit 83e2c37
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/table-core/src/types.ts
Expand Up @@ -200,12 +200,12 @@ export type StringOrTemplateHeader<TData, TValue> =
| string
| ColumnDefTemplate<HeaderContext<TData, TValue>>

interface StringHeaderIdentifier {
export interface StringHeaderIdentifier {
header: string
id?: string
}

interface IdIdentifier<TData extends RowData, TValue> {
export interface IdIdentifier<TData extends RowData, TValue> {
id: string
header?: StringOrTemplateHeader<TData, TValue>
}
Expand Down Expand Up @@ -265,7 +265,7 @@ export type AccessorFnColumnDef<
TValue = unknown,
> = AccessorFnColumnDefBase<TData, TValue> & ColumnIdentifiers<TData, TValue>

interface AccessorKeyColumnDefBase<TData extends RowData, TValue = unknown>
export interface AccessorKeyColumnDefBase<TData extends RowData, TValue = unknown>
extends ColumnDefBase<TData, TValue> {
id?: string
accessorKey: (string & {}) | keyof TData
Expand Down

0 comments on commit 83e2c37

Please sign in to comment.