fix(types): export types IdIdentifier, StringHeaderIdentifier, AccessorKeyColumnDefBase #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orKeyColumnDefBase fixes those build issues: TS4023: Exported variable 'myHook' has or is using name 'AccessorKeyColumnDefBase' from external module ".../node_modules/@tanstack/table-core/build/lib/types" but cannot be named. TS4023: Exported variable 'myHook' has or is using name 'IdIdentifier' from external module ".../node_modules/@tanstack/table-core/build/lib/types" but cannot be named. TS4023: Exported variable 'myHook' has or is using name 'StringHeaderIdentifier' from external module ".../node_modules/@tanstack/table-core/build/lib/types" but cannot be named.
|
I am also seeing this issue when exporting an array of columns. It only happens when the array is exported and there are two or more different string-extending types, such as a string and a string|null, or a string and a string literal. Minimal reproduction: const cd = createColumnHelper<{a: 'a'; b:string}>();
export const cols = [
cd.accessor("a", {}),
cd.accessor("b", {}),
]; |
2 tasks
|
Started doing some refactoring and moved my column helpers into their own file, added export and now getting exactly the same issue! |
|
@maxence-lefebvre is there any ETA on this getting to production? |
ShrihariBala
approved these changes
Nov 16, 2023
|
Any chance to merge this fix? @maxence-lefebvre |
I am not a contributor and am therefore not allowed to merge on this repository 😄 Thanks |
|
@tannerlinsley Could you review this please? |
KevinVandy
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is a short pull request to add some missing "export" clauses to some types.
Using a nx monorepo, one of my buildable modules fails to build with the following errors:
I have yarn linked react-table and table-core, and it resolved my build issues.
Thank you for considering this issue, and I hope you find this helpful.