Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rework publish script #5240

Merged
merged 9 commits into from Dec 30, 2023
Merged

fix: Rework publish script #5240

merged 9 commits into from Dec 30, 2023

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Dec 30, 2023

Changes:

  • Copied scripts/publish from tanstack-query (rewritten in JSDoc, updated logic)
  • Updated and added missing dependencies for script
  • Updated CI github workflow
  • Set "type": "module" as default for root-level files
  • Added explicit "type": "commonjs" to packages (not breaking since this is the default value)
  • Removed ts-node

I've marked it as a "fix" PR so that it will run the whole publish script. It does change the packages, so it is reasonable to publish anyway.

@lachlancollins lachlancollins changed the title chore: Rework publish script fix: Rework publish script Dec 30, 2023
@KevinVandy KevinVandy merged commit 5189d74 into TanStack:main Dec 30, 2023
1 check passed
@lachlancollins lachlancollins deleted the publish-script branch December 30, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants