Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Stricter tsconfig options #5264

Merged
merged 6 commits into from
Jan 6, 2024
Merged

chore: Stricter tsconfig options #5264

merged 6 commits into from
Jan 6, 2024

Conversation

lachlancollins
Copy link
Member

  • Re-ordered options to match other repos
  • Disabled allowUnreachableCode and allowUnusedLabels
  • Bumped module to ES2022 (does not affect build output)
  • Enabled forceConsistentCasingInFileNames, isolatedModules, resolveJsonModule
  • Removed baseUrl (not necessary with pnpm's workspace links)
  • Removed strictNullChecks (covered by strict)
  • Added options to enable in future (noImplicitReturns, noUnusedLocals, noUnusedParameters)
  • Moved jsx out of root config into relevant package configs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lachlancollins lachlancollins merged commit 86d6447 into TanStack:main Jan 6, 2024
@lachlancollins lachlancollins deleted the tsconfig branch January 6, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant