Merge pull request #112 from usagizmo/update/add-id-to-attr-handling

Fix id handling

src/nodes/html.ts

@@ -131,6 +131,7 @@ export default class HTMLElement extends Node {
 		super(parentNode);
 		this.rawTagName = tagName;
 		this.rawAttrs = rawAttrs || '';
+		this.id = keyAttrs.id || '';
 		this.childNodes = [];
 		this.classList = new DOMTokenList(
 			keyAttrs.class ? keyAttrs.class.split(/\s+/) : [],
@@ -139,7 +140,6 @@ export default class HTMLElement extends Node {
 			)
 		);
 		if (keyAttrs.id) {
-			this.id = keyAttrs.id;
 			if (!rawAttrs) {
 				this.rawAttrs = `id="${keyAttrs.id}"`;
 			}
@@ -609,6 +609,10 @@ export default class HTMLElement extends Node {
 			}
 			return `${name}=${val}`;
 		}).join(' ');
+		// Update this.id
+		if (key === 'id') {
+			this.id = '';
+		}
 	}
 
 	public hasAttribute(key: string) {
@@ -653,6 +657,10 @@ export default class HTMLElement extends Node {
 			}
 			return `${name}=${val}`;
 		}).join(' ');
+		// Update this.id
+		if (key === 'id') {
+			this.id = value;
+		}
 	}
 
 	/**

test/112.js

@@ -0,0 +1,39 @@
+const { parse, HTMLElement } = require('../dist');
+
+// https://github.com/taoqf/node-html-parser/pull/112
+describe('pull/112', function () {
+	it('this.id is set to an empty string', async function () {
+		const el = new HTMLElement('div', {}, '', null);
+		el.id.should.eql('')
+		should.equal(el.getAttribute('id'), undefined);
+		el.toString().should.eql('<div></div>');
+	});
+	it('this.id is set to the value of keyAttrs', async function () {
+		const el = new HTMLElement('div', { id: 'id' }, 'id="id"', null);
+		el.id.should.eql('id')
+		el.getAttribute('id').should.eql('id')
+		el.toString().should.eql('<div id="id"></div>');
+	});
+	it('#removeAttribute()', async function () {
+		const html = '<div id="id"></div>';
+		const root = parse(html);
+		const el = root.firstChild;
+		el.id.should.eql('id')
+		el.getAttribute('id').should.eql('id')
+		el.removeAttribute('id')
+		el.id.should.eql('')
+		should.equal(el.getAttribute('id'), undefined);
+		el.toString().should.eql('<div></div>');
+	});
+	it('#setAttribute()', async function () {
+		const html = '<div></div>';
+		const root = parse(html);
+		const el = root.firstChild;
+		el.id.should.eql('')
+		should.equal(el.getAttribute('id'), undefined);
+		el.setAttribute('id', 'id')
+		el.id.should.eql('id')
+		el.getAttribute('id').should.eql('id')
+		el.toString().should.eql('<div id="id"></div>');
+	});
+});