New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id handling #112

Merged

taoqf merged 2 commits into taoqf:main from usagizmo:update/add-id-to-attr-handling

Apr 12, 2021

usagizmo commented Apr 11, 2021

Change this.id to required property
Fixed a problem where the this.id (string) was sometimes undefined.
Fix setAttributes() / removeAttributes() to affect this.id
I used the behavior of the chrome browser as a reference.

usagizmo added 2 commits

April 11, 2021 13:49


          Change this.id to a required field

2bee38f


          Fix setAttributes / removeAttributes to affect this.id

0ab164a

taoqf approved these changes

View reviewed changes

Owner

taoqf left a comment

Many thanks for your work!

taoqf merged commit b2ddd86 into taoqf:main

usagizmo deleted the update/add-id-to-attr-handling branch

April 12, 2021 12:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment