Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require cycle warning for dist/nodes/html.js in version 3.1.5 #114

Closed
denisgrenader opened this issue Apr 21, 2021 · 2 comments
Closed

Require cycle warning for dist/nodes/html.js in version 3.1.5 #114

denisgrenader opened this issue Apr 21, 2021 · 2 comments

Comments

@denisgrenader
Copy link

Require cycle: node_modules/node-html-parser/dist/nodes/html.js -> node_modules/node-html-parser/dist/parse.js -> node_modules/node-html-parser/dist/nodes/html.js

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle
@denisgrenader denisgrenader changed the title Remove require cycle warning for dist/nodes/html.js in version 3.1.5 Require cycle warning for dist/nodes/html.js in version 3.1.5 Apr 21, 2021
taoqf added a commit that referenced this issue Apr 22, 2021
@taoqf
fix issue: #114
bb4add0
@taoqf
Copy link
Owner

taoqf commented Apr 22, 2021

thank you, try v3.1.6, let me know if there are still issues.

@denisgrenader
Copy link
Author

Thank you @taoqf -- cyclic warning gone in v3.1.6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@denisgrenader @taoqf