Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextElementSibling returns an HTMLElement #118

Merged
merged 1 commit into from May 22, 2021
Merged

nextElementSibling returns an HTMLElement #118

merged 1 commit into from May 22, 2021

Conversation

hugmanrique
Copy link

@hugmanrique hugmanrique commented May 7, 2021 •
edited

The purpose of nextElementSibling is to return an HTMLElement, not any kind of Node (DOM standard).
The .tsconfig disables strict null-checking, so I forgo adding the null return type.

@hugmanrique
nextElementSibling returns an HTMLElement
607c003 
The purpose of `nextElementSibling` is to return an `HTMLElement`, not any kind of `Node`.
The `.tsconfig` disables strict null-checking, so I forgo adding the `null` return type.
taoqf
taoqf approved these changes May 22, 2021
View reviewed changes
Copy link
Owner

@taoqf taoqf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@taoqf taoqf merged commit bc6ba6e into taoqf:main May 22, 2021
@taoqf
Copy link
Owner

taoqf commented May 22, 2021

https://github.com/taoqf/node-html-parser/releases/tag/v3.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoqf taoqf taoqf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugmanrique @taoqf