Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not report skipped tests? #8

Open
davidmason opened this issue Oct 2, 2015 · 2 comments
Open

Does not report skipped tests? #8

davidmason opened this issue Oct 2, 2015 · 2 comments

Comments

@davidmason
Copy link

I am piping output from tape 4.2.0 into faucet, I'm not sure if this issue is caused by tape output or by faucet.

According to what appears to be the tap spec, lines like this should count as skipped:

ok 23 # skip Insufficient flogiston pressure.

If the whole test file succeeds, the count of skipped tests is included in the generated output. The harness should report the text after # SKIP\S*\s+ as a reason for skipping.

Tape does not appear to output anything for skipped tests, and skipped assertions have # SKIP appended to the message rather than prepended.

faucet does not display tests that have skipped assertions any differently, even if I edit the output to make the skipped test lines look like the one in the spec (move # skip to just after the assertion number) and has nothing in the final lines about skipped tests.

@awlayton
Copy link

@davidmason tape is doing the right thing (or at least a compliant thing) for skipped tests.

From the TAP spec:

To summarize: - ok/not ok (required) - Test number (recommended) - Description (recommended) - Directive (only when necessary)

There can still be a description before the directive. You can also have an explanation/reason after the start of the directive which tape does not support, but the output is still spec compliant.

I would also like faucet to report my tests with skip (and todo) directives in some way.

@awlayton
Copy link

It seems that now it reports skip tests as passing, which I _really_ want to stop...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants