From 135a952e55372855b1510a6381e5a5757758b452 Mon Sep 17 00:00:00 2001
From: Jordan Harband <ljharb@gmail.com>
Date: Thu, 21 Sep 2023 13:55:49 -0700
Subject: [PATCH] [Refactor] prefer second `.then` arg over `.catch`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Since `.then` is always present, but `.catch` isn’t
---
 lib/test.js | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/lib/test.js b/lib/test.js
index 3353d5bb..43bf905e 100644
--- a/lib/test.js
+++ b/lib/test.js
@@ -116,18 +116,21 @@ Test.prototype.run = function run() {
         && typeof callbackReturn.then === 'function'
 	) {
 		var self = this;
-		Promise.resolve(callbackReturn).then(function onResolve() {
-			if (!self.calledEnd) {
+		Promise.resolve(callbackReturn).then(
+			function onResolve() {
+				if (!self.calledEnd) {
+					self.end();
+				}
+			},
+			function onError(err) {
+				if (err instanceof Error || objectToString(err) === '[object Error]') {
+					self.ifError(err);
+				} else {
+					self.fail(err);
+				}
 				self.end();
 			}
-		})['catch'](function onError(err) {
-			if (err instanceof Error || objectToString(err) === '[object Error]') {
-				self.ifError(err);
-			} else {
-				self.fail(err);
-			}
-			self.end();
-		});
+		);
 		return;
 	}