Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing in TAP output indicating skipped tests #115

Closed
aghassemi opened this issue Nov 6, 2014 · 3 comments
Closed

Nothing in TAP output indicating skipped tests #115

aghassemi opened this issue Nov 6, 2014 · 3 comments

Comments

@aghassemi
Copy link
Contributor

When a whole test is skipped using test.skip(), there is nothing in the TAP output indicating that fact. (only skipped assertions show up as # SKIP in TAP out)

I am not sure if putting SKIP directive on the test line is valid TAP, I think it is not, so maybe we can output something like this for an skipped tests:

# MyTest
# ok 1 # SKIP MyTest has been skipped.

This can help skipped tests "not get lost" since CI reporters can report on number of skipped tests and set builds to failed or at least unstable when there are skipped tests.

@aghassemi
Copy link
Contributor Author

Also a question: if I have an assertion that I want to skip temporarily, what's the way to do it? I expected either t.equal(foo, bar).skip('skipped until baz is ready') or t.skip('skipped until baz is ready').equal(foo, bar) to work but neither seem to do it.

@fraserc
Copy link

fraserc commented Jul 8, 2015

+1 for this as not having reporting of skipped tests seems a bit odd. I'm doing QA with a team where I'll skip tests I know fail, so that the devs can pick them up later and fix them up.

@r0mflip
Copy link
Contributor

r0mflip commented Jan 7, 2020

Fixed in #476 ...

@ljharb ljharb closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants