-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old Browser Support With Browserify #456
Comments
That's an interesting dilemma. I'd be happy to accept a PR into In general, though, I think |
@ljharb I don't suppose there's a way to simply remove the reliance on Buffer at all in Tape, therefore preventing Browserify from trying to add its polyfill? I just tested on IE9. The tests don't even start because something (probably again related to Buffer) triggers an uncaught error about Uint8Array not being supported by the browser (which is correct, but unhelpful). |
It looks like the usage of |
Checking in. Any progress on this front? |
There’s no progress because there’s nothing actionable yet. I’d suggest filing an issue on browserify itself to use v4 of Buffer. |
Given that the author of Tape personally approved of the change from Buffer v4 to v5 in Browserify, where he is listed as a collaborator, and acknowledged that this would break old IE support, I highly doubt he'd be willing to roll that back. However, I have asked him for assistance in what to do there too. |
Closing in favor of discussion: browserify/browserify#1678 (comment) |
When testing in IE10 (and probably lower) with Tape, an error will occur:
Browserify switched its dependency on Buffer from v4 to v5 on January 24th, 2017. Buffer v5 officially drops support for IE8 through IE10.
I was able to determine that it is Tape (or one of its dependencies), and not my code, that is making use of Buffer, and therefore triggering Browserify to attempt to include its polyfill(?), which then triggers the error in older versions of IE.
Like Tape, I'm attempting to build my library to support (and be testable) in as many browsers as possible, including older versions of IE. This means that while I can certainly use an older version of Browserify, or build my tests with two different versions of Browserify at the same time, there are some major potential side-effects of doing so:
Since Browserify is the "recommended" method of bundling Tape tests for the Browser, and since Tape claims to support IE6 through IE10, yet current versions of Browserify don't fully support Tape, how does one square this circle?
The text was updated successfully, but these errors were encountered: