Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es-abstract tests blow the stack in node < 6 #598

Open
ljharb opened this issue Jul 12, 2023 · 0 comments
Open

es-abstract tests blow the stack in node < 6 #598

ljharb opened this issue Jul 12, 2023 · 0 comments

Comments

@ljharb
Copy link
Collaborator

ljharb commented Jul 12, 2023

See ljharb/es-abstract@156bf41.

When that flag is removed, tape will blow the stack running tests in es-abstract - nvm exec 6.0 npm run tests-only passes, but nvm exec 5 npm run tests-only fails. nvm exec 5 node test/bufferTestCases also fails if you want a smaller repro.

I haven't yet been able to improve tape's stack performance by enough to get the tests to complete in node < 6 without providing the --stack-size option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant