Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing js with </script> string fails #89

Open
RGBboy opened this issue Aug 6, 2014 · 0 comments · May be fixed by #90
Open

testing js with </script> string fails #89

RGBboy opened this issue Aug 6, 2014 · 0 comments · May be fixed by #90

Comments

@RGBboy
Copy link

RGBboy commented Aug 6, 2014

If you are testing any js that has </script> within it the script tag where the bundled js gets added will be closed early, resulting in failing tests.

A potential solution to this is to not put the bundle between script tags and instead serve it as a script via a dummy url.
@RGBboy RGBboy changed the title testing js with </script> string fails test testing js with </script> string fails Aug 6, 2014
RGBboy added a commit to RGBboy/testling that referenced this issue Aug 6, 2014
@RGBboy
Updated generated html to point to bundle url;
d71a21d 
Fixes tape-testing#89;
@RGBboy RGBboy linked a pull request Aug 6, 2014 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated generated html to point to bundle url; RGBboy/testling
1 participant
@RGBboy