"exclude" field in .nycrc.json no longer works

[jaydenseric]

The exclude field in .nycrc.json no longer works. I'm guessing a recent tap release started adding some defaults, causing the config file field to be ignored.

Ideally the defaults would augment, and not replace, user config.

[coreyfarrell]

nyc doesn't have an excludes option, it's exclude.

[jaydenseric]

@coreyfarrell thanks, I did a typo and meant to say exclude; I was in fact using the right one:

jaydenseric/graphql-upload@0f92002#diff-ef814fc9852f9384bea581fd0673977dL2

[isaacs]

Yeah, tap started explicitly excluding all test files from coverage, since that's almost never what you want (and it led to some weird bad behavior in some cases).

I've been chatting with @coreyfarrell about better ways to structure the tap/nyc integration. It's a bit of weird interface boundary right now, and I think there are a few small improvements we could make on either side to avoid issues like this.

[goto-bus-stop]

We ended up using "tap"."nyc-arg" instead of "nyc" here: clinicjs/node-clinic-flame@8adf4c4

[isaacs]

Nyc no longer used in tap 18. Check it out with npm i tap@pre. https://node-tap.org/changelog/#18.0