Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.4 has a breaking change #66

Closed
ljharb opened this issue Sep 24, 2021 · 0 comments
Closed

v3.0.4 has a breaking change #66

ljharb opened this issue Sep 24, 2021 · 0 comments

Comments

@ljharb
Copy link
Member

ljharb commented Sep 24, 2021 •
edited

v3.0.4 contains an arrow function, which <= v3.0.3 did not; this is breaking tape (or tape's tests, i'm not sure yet).

Can a v3.0.5 be released that uses function () {} instead?

(Update: this dep is included in nyc v9, and tap v8, and execa v1, and os-locale v3, and libnpx v10, to name a few; some of those are surely breaking changes too)
ljharb added a commit that referenced this issue Sep 24, 2021
@ljharb
[Fix] unbreak v3
df24982 
Fixes #66
@ljharb ljharb mentioned this issue Sep 24, 2021
Closed
ljharb added a commit to tape-testing/tape that referenced this issue Sep 24, 2021
@ljharb
[Dev Deps] ping signal-exit to v3.0.3 due to tapjs/signal-exit#66
3c30a55
@isaacs isaacs closed this as completed in 5535eeb Sep 29, 2021
ljharb added a commit to tape-testing/tape that referenced this issue Oct 8, 2021
@ljharb
Revert "[Dev Deps] ping signal-exit to v3.0.3 due to tapjs/signal-e…
60bbd83 
…xit#66"

This reverts commit 3c30a55.
This was referenced Dec 7, 2021
Open
Merged
Merged
Merged
Closed
Merged
Open
@snyk-bot snyk-bot mentioned this issue Dec 16, 2021
Merged
This was referenced Jan 28, 2022
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Feb 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] unbreak v3 tapjs/signal-exit
1 participant
@ljharb