wal: fix wal_queue_max_size assignment during initial box.cfg #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepetrenko
force-pushed
the
apply-wal-queue-max-size
branch
from
54b051e
to
2b7a78c
Compare
xuniq
approved these changes
May 16, 2024
Serpentian
approved these changes
May 16, 2024
Gerold103
approved these changes
May 17, 2024
sergepetrenko
added
full-ci
wal_queue_max_size took effect only after the initial box.cfg call, meaning that users with non-zero `replication_sync_timeout` still synced using the default 16 Mb queue size. In some cases the default was too big and the same issues described in tarantool#5536 arose. Fix this. Closes tarantool#10013 NO_DOC=bugfix
sergepetrenko
force-pushed
the
apply-wal-queue-max-size
branch
from
2b7a78c
to
0593032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wal_queue_max_size took effect only after the initial box.cfg call, meaning that users with non-zero
replication_sync_timeoutstill synced using the default 16 Mb queue size. In some cases the default was too big and the same issues described in #5536 arose.Fix this.
Closes #10013
NO_DOC=bugfix