vinyl: fix index build crash on invalid UPSERT #10027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no regression test in the patch. I cannot guarantee that fuzzing test will cover patches for all found bugs. So there is a non-zero possibility that bug #10026 will happen again in the future. |
Like UPDATE, UPSERT must not modify primary key parts. Unlike UPDATE,
such an invalid UPSERT statement doesn't fail (raise an error) - we
just log the error and ignore the statement. The problem is, we don't
clear txn_stmt. As a result, if we're currently building a new index,
the on_replace trigger installed by the build procedure will try to
process this statement, triggering the assertion in the transaction
manager that doesn't expect any statements in a secondary index without
the corresponding statement in the primary index:
./src/box/vy_tx.c:728: vy_tx_prepare:
Assertion `lsm->space_id == current_space_id' failed.
Let's fix this by clearing the txn_stmt corresponding to a skipped
UPSERT.
Note, this also means that on_replace triggers installed by the user
won't run on invalid UPSERT (hence test/vinyl/on_replace.result update),
but this is consistent with the memtx engine, which doesn't run them
in this case, either.
Closes tarantool#10026
NO_DOC=bug fix
locker
force-pushed
the
vy-index-build-crash-on-invalid-upsert-fix
branch
from
87b72b6
to
e582882
Compare
Added a regression test. |
xuniq
approved these changes
May 20, 2024
|
The |
|
Cherry-picked to 2.11 and 3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
UPDATE,UPSERTmust not modify primary key parts. UnlikeUPDATE, such an invalidUPSERTstatement doesn't fail (raise an error) - we just log the error and ignore the statement. The problem is, we don't cleartxn_stmt. As a result, if we're currently building a new index, theon_replacetrigger installed by the build procedure will try to process this statement, triggering the assertion in the transaction manager that doesn't expect any statements in a secondary index without the corresponding statement in the primary index:Let's fix this by clearing the
txn_stmtcorresponding to a skippedUPSERT.Note, this also means that
on_replacetriggers installed by the user won't run on invalidUPSERT(hencetest/vinyl/on_replace.resultupdate), but this is consistent with the memtx engine, which doesn't run them in this case, either.Closes #10026