Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log messages not parsed by Stackdriver #47

Closed
MrWako opened this issue Feb 28, 2020 · 4 comments
Closed

Log messages not parsed by Stackdriver #47

MrWako opened this issue Feb 28, 2020 · 4 comments
Assignees

Comments

@MrWako
Copy link
Contributor

MrWako commented Feb 28, 2020

Firstly thank you for creating this tool - I really like its simplicity. I've been experimenting with it on GCP and whilst not really an issue with pod-reaper, the default Logrus structured logs do not get handled well by the fleuntd/stackdriver collectors, and all the log messages, regardless of severity, get logged as Errors.

I've put together a small PR to allow for different formatting of the logs, let me know what you think.

@brianberzins
Copy link
Collaborator

Oh wow! I remember looking at this! I think it's actually deeper than logrus! I think I recall it actually being a golang thing (that some logging frameworks built around!)

Greatly appreciate the kind words. I'll see what I can do to help make it work :-)

@brianberzins brianberzins self-assigned this Feb 28, 2020
@brianberzins
Copy link
Collaborator

I wish I could find where I found this when I first looked into everything-getting-logged-to-stderr... but I haven't been able to find it yet.

Some interesting back and forth here:
sirupsen/logrus#403 (comment)

@brianberzins
Copy link
Collaborator

@MrWako
Merged and released as 2.5.0! Can you confirm that it's working for you with stack driver?

If everything logging to stderr is painful, I can dig deeper into this. In the most extreme case, it should be possible to force it into using stdout (but I'd want to really understand why they chose stderr if I'm looking to change it)

@brianberzins
Copy link
Collaborator

Marking as closed, if something isn't working, please feel free to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants