From 40b2fa4832a83b975c9d2620f49341690f40bc65 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 21 Oct 2020 08:50:37 +0200 Subject: [PATCH] deps: V8: cherry-pick 45e49775f5a3 Original commit message: [arm64][msvc] fix arm64 build on msvc See: https://github.com/nodejs/node/pull/35415#issuecomment-707828213 Co-authored-by: Richard Townsend Change-Id: I440644f55dc8c8ec3108e5015ebbce2829dd8207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2479602 Reviewed-by: Jakob Gruber Commit-Queue: Jakob Gruber Auto-Submit: Jiawen Geng Cr-Commit-Position: refs/heads/master@{#70648} Refs: https://github.com/v8/v8/commit/45e49775f5a366e4d56de8a043da9d6093d9510e PR-URL: https://github.com/nodejs/node/pull/35700 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Joyee Cheung Reviewed-By: Matteo Collina Reviewed-By: Jiawen Geng Reviewed-By: Shelley Vohr --- common.gypi | 2 +- .../src/snapshot/embedded/platform-embedded-file-writer-win.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index d9d29fdca1579c..aaedbd14bfe597 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.13', + 'v8_embedder_string': '-node.14', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.cc b/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.cc index 310da35a7e9ae6..e3250084c4ded3 100644 --- a/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.cc +++ b/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.cc @@ -485,7 +485,7 @@ void PlatformEmbeddedFileWriterWin::Comment(const char* string) { void PlatformEmbeddedFileWriterWin::DeclareLabel(const char* name) { if (target_arch_ == EmbeddedTargetArch::kArm64) { - fprintf(fp_, "%s%s\t", SYMBOL_PREFIX, name); + fprintf(fp_, "%s%s\n", SYMBOL_PREFIX, name); } else { fprintf(fp_, "%s%s LABEL %s\n", SYMBOL_PREFIX, name,