From ad3513fd7fb734adedbd4d5d14782d11b9d0319e Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 21 Mar 2024 20:07:54 +0000 Subject: [PATCH] deps: V8: cherry-pick f8d5e576b814 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski Commit-Queue: Milad Farazmand Cr-Commit-Position: refs/heads/main@{#92252} Refs: https://github.com/v8/v8/commit/f8d5e576b814c92c39ec0cea80c21e4162270e12 PR-URL: https://github.com/nodejs/node/pull/52183 Refs: https://github.com/v8/v8/commit/c4be0a97f981ce08bad854684c941e4c98647025 Reviewed-By: Jiawen Geng Reviewed-By: Marco Ippolito Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca --- common.gypi | 2 +- deps/v8/BUILD.gn | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 18f60c1435c6ef..0e028e3bf97d97 100644 --- a/common.gypi +++ b/common.gypi @@ -37,7 +37,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.7', + 'v8_embedder_string': '-node.8', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/BUILD.gn b/deps/v8/BUILD.gn index bc087fd6fee47b..94f48cc4a7d892 100644 --- a/deps/v8/BUILD.gn +++ b/deps/v8/BUILD.gn @@ -1696,6 +1696,10 @@ config("toolchain") { # of `this` in capture-by-value lambdas and preventing a build roll which # enables C++20 (see https://crbug.com/1374227). "-Wno-deprecated", + + # Fix build with older versions of GCC + # Ported from v8 bazel: https://crrev.com/c/3368869 + "-Wno-stringop-overflow", ] }