Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enzyme button click for the the account creation test after updating the SDK #43

Open
pcowgill opened this issue Dec 19, 2018 · 4 comments
Assignees
Labels
tech debt Technical debt not involving bugs or features
Projects
Milestone

Comments

@pcowgill
Copy link
Member

No description provided.

@pcowgill pcowgill added this to the 0.1.0 release milestone Dec 19, 2018
@pcowgill pcowgill added the tech debt Technical debt not involving bugs or features label Dec 19, 2018
@marcelomorgado
Copy link
Contributor

Actually, that isn't related to Expo SDK version.

Problem:
Enzyme.simulate('click') doesn't support async handlers (and doesn't will).
Refs: enzymejs/enzyme#867 (comment) and enzymejs/enzyme#898 (comment).

The Enzyme team recommends to call the handlerFunction directly for now.
It works well but exposes to test case an internal behavior of component that isn't a best practice.

The final solution will come when they add the invoke function to their API.
A PR already exists but it stills as a WIP: enzymejs/enzyme#1856

@pcowgill
Copy link
Member Author

@marcelomorgado In the new SDK version we published, I think the function in question isn't async anymore, right?

@pcowgill pcowgill added this to To do in Main via automation Jan 27, 2019
@pcowgill
Copy link
Member Author

Then again, I could see account creation getting slower again and changing to async depending on how we handle tasitlabs/tasit-sdk#24

@marcelomorgado
Copy link
Contributor

marcelomorgado commented Feb 10, 2019

@marcelomorgado In the new SDK version we published, I think the function in question isn't async anymore, right?

Right

Then again, I could see account creation getting slower again and changing to async depending on how we handle tasitlabs/TasitSDK#24

👍

Also, related to: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical debt not involving bugs or features
Projects
Main
  
To do
Development

No branches or pull requests

2 participants