Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(job): add changePriority method #1901

Merged
merged 8 commits into from May 31, 2023
Merged

feat(job): add changePriority method #1901

merged 8 commits into from May 31, 2023

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented May 16, 2023 •
edited

ref #1899

@roggervalf roggervalf marked this pull request as ready for review May 17, 2023 01:55
@roggervalf roggervalf requested a review from manast May 17, 2023 04:19
manast
manast reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess we need some piece of documentation on how to use this method and also explaning that it can only be used when the job is waiting.

manast
manast reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few grammar issues

docs/gitbook/guide/jobs/delayed.md Outdated
```

{% hint style="warning" %}
Take in count that your job must be in delayed state when you change the delay.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in -> into

docs/gitbook/guide/jobs/prioritized.md Outdated

## Change priority

If you want to change the priority after inserting a job, just use **changePriority** method. For example, let's say you want to change the priority from 16 to 1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> just use the changePriority method.

-> let's say that you want to change...

@roggervalf roggervalf merged commit 9485ad5 into master May 31, 2023
9 of 10 checks passed
@roggervalf roggervalf deleted the changePriority branch May 31, 2023 22:52
github-actions bot pushed a commit that referenced this pull request May 31, 2023
@semantic-release-bot
chore(release): 3.15.0 [skip ci]
1ccf486 
# [3.15.0](v3.14.2...v3.15.0) (2023-05-31)

### Features

* **job:** add changePriority method ([#1901](#1901)) ref [#1899](#1899) ([9485ad5](9485ad5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manast manast manast left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roggervalf @manast