Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'install_requires' to include semver #1927

Merged
merged 3 commits into from May 29, 2023

Conversation

maretodoric
Copy link
Contributor

When installing version 4.0.1 on freshly configured python virtual environment, and when attempting to import bullmq module, I've noticed error message:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/mtodoric/dev-in-progress/fapi_esalertmanager/esam_test/lib/python3.10/site-packages/bullmq/__init__.py", line 10, in <module>
    from bullmq.queue import Queue
  File "/home/mtodoric/dev-in-progress/fapi_esalertmanager/esam_test/lib/python3.10/site-packages/bullmq/queue.py", line 3, in <module>
    from bullmq.scripts import Scripts
  File "/home/mtodoric/dev-in-progress/fapi_esalertmanager/esam_test/lib/python3.10/site-packages/bullmq/scripts.py", line 9, in <module>
    from bullmq.utils import isRedisVersionLowerThan
  File "/home/mtodoric/dev-in-progress/fapi_esalertmanager/esam_test/lib/python3.10/site-packages/bullmq/utils.py", line 1, in <module>
    import semver
ModuleNotFoundError: No module named 'semver'

This PR should include semver as dependeny and fix this issue.
requirements.txt already seems to be updated.

Copy link
Collaborator

@roggervalf roggervalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@roggervalf roggervalf merged commit ce86ece into taskforcesh:master May 29, 2023
10 checks passed
github-actions bot pushed a commit that referenced this pull request May 30, 2023
## [3.14.2](v3.14.1...v3.14.2) (2023-05-30)

### Bug Fixes

* **python:** fix 'install_requires' to include semver ([#1927](#1927)) ([ce86ece](ce86ece))
* **rate-limit:** take in count priority ([#1919](#1919)) fixes [#1915](#1915) ([b8157a3](b8157a3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants