You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure we need Redux here, the other examples don't have it
Let's try to be 1:1 on CSS solutions - others are using Tailwind CSS, so use that
To be a more accurate comparison with other frameworks server-first, I recommend exploring the app directory
I would avoid ejecting the webpack plugin
Can probably remove a lot of the custom react-* packages added, which are increasing client JS, in comparison to other framework examples which aren't doing this
The text was updated successfully, but these errors were encountered:
As it turns out, I've been re-reading the source to https://next-movie.transitivebullsh.it/ this weekend and fully agree that a refactor that accounts for the points you listed would make sense. My ideal for this implementation would be using Next.js 13 with AppDir.
I see that while the OG implem you linked to is using AppDir, the author appears to be considering reverting back to pages: transitive-bullshit/next-movie#1. @leerob if we ignore the theming issue, do you have insight into whether I should wait for vercel/next.js#43159 to be addressed? We can of course just opt for a pages implementation in the refactor, but would be great to actually use AppDir.
I've gone ahead and made sure we are at least linking to the above implementation as part of the community alternatives section in the TasteJS Movies header over on the main site: https://tastejs.com/movies/
@ transitive-bullshit fyi. I really do like the implementation you wrote up btw. The choices of navigation modes was cool and I also thought it was an interesting idea to support GitHub (vs TMDB) auth for the wishlist.
A few things to note:
app
directoryreact-*
packages added, which are increasing client JS, in comparison to other framework examples which aren't doing thisThe text was updated successfully, but these errors were encountered: